Mobile first Coming Soon page with Js

Solution retrospective
Opinions? Could have done it with only HTML and CSS but wanted to practice JavaScript as well :)
Please log in to post a comment
Log in with GitHubCommunity feedback
- @ApplePieGiraffe
Hey, Vivien Bálint! 👋
Nice job on this challenge (as usual)! Your solution looks good and scales up/down quite well! 👍
It would be worth switching to a mobile-friendly layout somewhere below 1414px, since (as tediko suggested) the hero image is very large and there's still some space for the desktop layout (and you can create even more space by allowing the width of the image to decrease with the width of the screen—just add
object-fit: cover
to the image to make sure it doesn't get distorted). 😉Keep coding (and happy coding, too)! 😁
- @tediko
Hello, Vivien Bálint! 👋
Congratulations on finishing this challenge! Your solution responds well. What i can suggest is:
-
Image below 1400width screen sizes is huge. Add some
max-width
to prevent that and keep it nice. -
I believe you forgot disable default error tool-tip from browser. Now if i type wrong email your invalid message is overflow by browser default message. Your error message
font-size
is also a bit to small. -
Give your input some aria-label for accessibility.
If you want to see how I made this challenge, here is the link. Like most people here I also learn but maybe you will find something good for yourself.
Good luck with that, have fun coding! 💪
-
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord