Mobile first countdown timer with BEM and Sass

Community feedback

• 

  Rio Cantre•9,650

  @RioCantre

  Posted over 3 years ago

  Hello there! Awesome job with this challenge! Viewing your solution, you did well with the design and functionality. I would suggest the following for you..

  • Adjust the bottom margin of the icons in the .social__icons into 4rem
  • Import the attribution style in the CSS file and remove style tag
  • You can simplify the footer icon with this HTML structure...

  <li class="social__icon">
            <a href="#" class="icon icon--facebook"></a>
   </li>
  
  

  Over all you did well and Keep up the good work!

  04

  Marked as helpful
• 

  Travolgi 🍕•31,300

  @denielden

  Posted over 3 years ago

  Hi Yemisrach, congrats on completing the challenge!

  I had a look at your solution and I have a few suggestions to improve your code:

  • Try to use Flexbox for center the element in the page: read here ->Flex guide Note: Flexbox aligns to the size of the parent container.
  • To fix the position of the hill image in the background change the value of background-size in contain.
  • Try to adding a little transition on the social hover effect
  • In javascript avoid using innerHTML unless strictly necessary: its use creates a security hazard. Rather use innerText which is the same thing but does not parser html [read here] (https://www.w3schools.com/jsref/prop_node_innertext.asp)

  In the end Instead of using 4 identical functions that perform the same task but with different times, try to use only 1 function by passing it the different parameters.

  Overall you did well :) keep it up and Happy coding!

  03

  Marked as helpful