Mobile First Design using HTML and CSS

Community feedback

• 

  P

  Daniel 🛸•44,810

  @danielmrz-dev

  Posted over 1 year ago

  Hello @Patrickodida!

  Your project looks great!

  I have a couple of suggestions for you to improve it even more:

  • Using margin is not the best option to center an element. Here's a very efficient (and better) way to place an element in the middle of the page both vertically and horizontally:

  📌 Apply this to the body (in order to work properly, don't use position or margins):

  body {
      min-height: 100vh;
      display: flex;  /* it works with grid too  */
      justify-content: center;
      align-items: center;
  }
  

  📌 Also, in order to make your HTML code more semantic, don't skip heading levels - start with <h1>, then use <h2>, and so on. Unlike what most people think, it's not just about the size and weight of the text.

  • The <h1> to <h6> tags are used to define HTML headings.
  • <h1> defines the most important heading.
  • <h6> defines the least important heading.
  • Only use one <h1> per page - this should represent the main heading/title for the whole page.

  All these tag changes may have little or any visual impact but they make your HTML code more semantic and improve SEO optimization as well as the accessibility of your project.

  I hope it helps!

  Other than that, great job!

  01

  Marked as helpful
• 

  Rawan Mohamed•150

  @rawannmmohamed

  Posted over 1 year ago

  i would suggest using <h1> for the first part and give it the size you want and <p> for the second part .. it is better for accessibility to start with <h1> rather than <h3> .

  and span will create an inline element it won't be good to use it in this case.

  for more accessibility tips read this :

  https://www.frontendmentor.io/articles/10-fundamental-web-accessibility-tips-for-frontend-developers-rUurADGxCt

  01

  Marked as helpful
• 

  P

  Justin Green•2,940

  @jgreen721

  Posted over 1 year ago

  Your approach of <h3> and <p> tags was a good one. I'm not going to pretend to be an expert but the span element is a special inline element and isn't so much related to text-size. Inline meaning it won't 'block' down to the next level. A simple manner I'd use in is with-in a text element where you'd like to style a portion of the text differently.

  <h3 class='red-text'>Here is some text to be red, <span class='fadein-animation'>this part can fade-in </span> but this and the beginning portion wont.</h3>

  lol, dumb example but hopefully it helps a little. Certainly no shortage of long winded explanations on all of the elements to learn more but yea, your approach here was good.

  01

  Marked as helpful
• 

  Alok Suman•2,360

  @Alokray007

  Posted over 1 year ago

  Hello there 👋

  Good job on completing the challenge !

  Your project looks really good!

  I have a suggestion about your code that might interest you.

  There is an very useful browser extension called Perfect Pixel that allow you compare with the design image and thus see the exact dimensions. I recommend it to you.

  📌 Tags like <div> and <span> are typical examples of non-semantic HTML elements. They serve only as content holders but give no indication as to what type of content they contain or what role that content plays on the page. This tag change does not impact your project visually and makes your HTML code more semantic, improving SEO optimization as well as the accessibility of your project.

  I hope this suggestion is useful for future projects.

  Other than that, great job!

  Happy coding.

  01