Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Mobile first design with Sass

@norman02

Desktop design screenshot for the Social proof section coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Feedback welcomed!

Community feedback

P
tediko 6,580

@tediko

Posted

Hello, John! 👋

Congrats on finishing another challenge. You're going like crazy 😅 I really like what you've done here. Here's my few suggestion:

  • Take a look at the moment when your site break to desktop (1000px width). Whole left site is cut. Try to fix that.
  • Change the alt attributes for the .profile images, as they don't add any extra context for screen reader users. Since your images are decorative your alt text should be provided empty (alt="") so that they can be ignored by assistive technologies.
  • You repeat your HTML code with stars images which is unnecessary. Find the way to use only one star image for a .stars. You can do it easily by using background-repeat approach in your css. Your approach is also good, I just give you an alternative.

Good luck with that, have fun coding! 💪

1

@norman02

Posted

@tediko Thanks for the great feedback!

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord