Mobile first FAQ Accordion Card using vanilla JavaScript and Sass

Community feedback

• 

  Anna Leigh•5,135

  @brasspetals

  Posted over 4 years ago

  Hi, Vivien! Congrats on completing your first challenge! 🎉

  You really did an excellent job here. Just a few small suggestions:

  • To clear up the issues on your report, simply add alt attributes and values to your imgs.
  • Playing around with percentage values for the height and width of the faq container would be a nice way of adding a little bit of responsiveness. When doing this I suggest also setting a max-width (and sometimes even a min-width) so things never get too stretched looking. I also suggest looking into Flexbox for future projects - very useful and definitely worth learning.

  Again, good job - looking forward to your next solution!

  20
• 

  

  ApplePieGiraffe•30,525

  @ApplePieGiraffe

  Posted over 4 years ago

  Oh, yes, great work, Vivien Bálint! 👏

  Your solution looks great and responds well! Your accordion card works well, too! 🙌

  Just follow brasspetals' suggestions and you should be good to go! 👍

  Keep coding (and happy coding, too)! 😁

  10
• 

  Vivien Bálint•290

  @vivienbalint

  Posted over 4 years ago

  Thanks to both of you! :)

  00