Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Mobile First Flexbox Solution

@awaiskorai

Desktop design screenshot for the Profile card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Tried my best, if anyone can provide feedback upon best practices and things that need to be improved. Would really appreciate. Thanks.

Happy Coding :D

Community feedback

P

@gsterczewski

Posted

👋 Hello awaiskorai,

I like your solution, it looks good and it is responsive.

Only thing that catches my eye is your usage of headings. I think in this context it may be confusing for screen readers for example.

Headings should describe sections of the page.

In this example you created heading to display age and paragraph to display name. I think you could consider using a different tag, but I could be wrong, so verify it yourself.

    <p class="name">Victor Crest</p>
    <h2 class="age heading">26</h2>

Anyway, great job.

Good day and happy coding.

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord