Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted almost 4 years ago

Mobile first - Fylo landing page (HTML-CSS/SASS)

Benjo Quilario•1,790
@benjoquilario
A solution to the Fylo landing page with two column layout challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


Hello👋

This is my 20th frontendmentor challenge. At first sight I really thought it easy but I guess It's not, because this is the first time I encounter double email validation, but still with some experiment and playing around I did it.

Feel free to drop you feedback and suggestion, I really appreciate it.

Thanks! 😁

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Mike Hayden-Moore•1,005
    @mickyginger
    Posted almost 4 years ago

    Hey Benjo, this is great! 🎉

    I think you can get more of a curve on the grey panel at the bottom, by using the SVG just at the bottom of the .hero div and then setting the background color of .about to match the SVG. You'll need to remove the margin at the bottom of the .hero and use padding instead.

    You've done a great job with the email validation, but I don't think you need to get the errorMessage span at the start of your script. You could retrieve the relevant span by traversing from event.target, either using nextElementSibling or parentElement.querySelector('.hero__form--error'):

    function setFormState(input, errorMessage, className, message) {
      input.classList.add(className);
      errorMessage.classList.add(className);
      errorMessage.textContent = message;
      errorMessage.style.animation = 'errorPop 350ms ease';
      setTimeout(() => {
        input.classList.remove('error', 'success');
        errorMessage.classList.remove('error success');
        errorMessage.style.animation = 'none';
      }, 3000);
    }
    
    function checkEmail(event) {
      event.preventDefault();
      const input = event.target.email;
      const errorMessage = input.nextElementSibling;
      if (!validateEmail(input.value)) {
        setFormState(input, errorMessage, 'error', 'Invalid Email, Please check your email');
      } else {
        setFormState(input, errorMessage, 'success', 'Email Successfully Submitted');
      }
    }
    

    I've also removed some of the duplication by creating a setFormState method, which hopefully makes the code a little less busy and easier to read.

    Finally I would recommend removing your commented code, it's not a big deal but it's the kind of thing that makes your code look a bit unprofessional, so it's probably better to remove it especially if you are applying for junior roles.

    Hope that helps! 😄

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Frontend Mentor for Teams

Frontend Mentor for Teams helps companies and schools onboard and train developers through project-based learning. Our industry-standard projects give developers hands-on experience tackling real coding problems, helping them master their craft.

If you work in a company or are a student in a coding school, feel free to share Frontend Mentor for Teams with your manager or instructor, as they may use it to help with your coding education.

Learn more

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub