Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Mobile first Order summary component

@adeyinkaezra123

Desktop design screenshot for the Order summary component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Your feedback is very much appreciated

Community feedback

@mdajmalshadab

Posted

Hey you have done it nicely, only you just need to reduce some bottom padding of the card, then it'll match with the given challenge. Keep coding ✌️

Marked as helpful

0
P
Ken 4,915

@kens-visuals

Posted

Hey @adeyinkaezra123 👋🏻

I have some suggestions to help you fix the accessibility, HTML and some other issues.

  • In HTML, I suggest removing <section>, then change <div class="container">...</div> to <main class="container">...</main> and <div class="attribution">...</div> should be <footer class="attribution">...</footer>.
  • Use forward slash -- /` for the images' path, like this `<img src=`images/illustration-hero.svg` alt=>`. These will fix the accessibility and HTML issues. Don't forget to generate a new repot once you fix the issues.
  • For the music icon, add aria-hidden="true”, because it's for decoration. You can read more about aria-hidden here.
  • Also, I suggest implementing :hover states, which you can find in Frontend Mentor's design folder, it should say active-state.
  • For the dancing illustration, make sure to add alt tag, that describes the image. Also, please don't include words like image of.. or illustration of..., because they would be redundant.
  • Lastly, change height of .container to min-height: 70vh;, it will allow the content to stay at 70vh but will also grow if needed.

I hope this was helpful 👨🏻‍💻 you did a good job for the second project, well done. Cheers 👾

Marked as helpful

0

@adeyinkaezra123

Posted

@kens-visuals Thanks, would do those right away Definitely learned new hacks

0
P
Ken 4,915

@kens-visuals

Posted

@adeyinkaezra123 you're welcome 😇

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord