@mdajmalshadab
Posted
Hey you have done it nicely, only you just need to reduce some bottom padding of the card, then it'll match with the given challenge. Keep coding ✌️
Marked as helpful
Looking to hire developers?
Your feedback is very much appreciated
@mdajmalshadab
Posted
Hey you have done it nicely, only you just need to reduce some bottom padding of the card, then it'll match with the given challenge. Keep coding ✌️
Marked as helpful
Hey @adeyinkaezra123 👋🏻
I have some suggestions to help you fix the accessibility, HTML and some other issues.
<section>
, then change <div class="container">...</div> to <main class="container">...</main> and <div class="attribution">...</div>
should be <footer class="attribution">...</footer>
.forward slash -- /` for the images' path, like this `<img src=`images/illustration-hero.svg` alt=
>`. These will fix the accessibility and HTML issues. Don't forget to generate a new repot once you fix the issues.aria-hidden="true”
, because it's for decoration. You can read more about aria-hidden
here.alt
tag, that describes the image. Also, please don't include words like image of..
or illustration of...
, because they would be redundant.height
of .container
to min-height: 70vh;
, it will allow the content to stay at 70vh
but will also grow if needed.I hope this was helpful 👨🏻💻 you did a good job for the second project, well done. Cheers 👾
Marked as helpful
@adeyinkaezra123
Posted
@kens-visuals Thanks, would do those right away Definitely learned new hacks
@adeyinkaezra123 you're welcome 😇
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord