Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Mobile First QR Code created using HTML5 Mark up & Customer Properties

@jchapar

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Hello, worked on keeping this very simple and not overthinking the entire markup. Any feedback would be greatly appreciated!

Community feedback

Travolgi 🍕 31,500

@denielden

Posted

Hi Jose, great work on this challenge! 😉

Here are a few tips for improve your code:

  • add descriptive text in the alt attribute of the images
  • remove all margin and padding from container class because with flex they are superfluous
  • use min-height: 100vh instead height to main tag and remove width

Overall you did well 😁 Hope this help!

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord