Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted 6 months ago

Mobile first responsive design

P
LaStellaa•570
@LaStellaa
A solution to the News homepage challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


What are you most proud of, and what would you do differently next time?

I am happy with the result overall, especially the responsiveness achieved with CSS Grid. I used the grid template areas and it worked great. I am understanding more and more the importance of a well structured HTML and i want to keep focusing on that.

What challenges did you encounter, and how did you overcome them?

Since it was my first time using grid areas, it took me a little bit of time to get it to work like i wanted to, especially the image. Another challenge was the menu on mobile screen, since i had to style it i could not use the display: none and had to rely on opacity 0 , which made my JS a bit more complicated that it could have been.

What specific areas of your project would you like help with?

If anyone has suggestions on how i can simplify my code, i am all ears!!

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Erick Rodrigues•660
    @SortJakke
    Posted 4 months ago

    Hello, here is some feedback on your project:

    Issues found:

    • On the page, each clickable article has a hover effect, but ideally, these elements should be links that allow users to access the full article. Making them keyboard-accessible is essential to ensure inclusive navigation.
    • The menu button is also not accessible via the keyboard, which affects the experience for users relying on this functionality.

    Suggestions for improvement:

    • You can simplify the HTML by adding the "grif-container" class directly to the <main> tag. Using two tags to contain the same content is redundant and can be avoided.
    • I recommend using a button (<button>) instead of an image (<img>) to open the menu, as it is semantically more appropriate and improves the page’s accessibility. Additionally, you could create two classes: one for the closed state and another for the open state. In JavaScript, you would simply toggle the classes, making the menu open script much simpler and more efficient.
    • In the main article, I suggest creating a single <section> and dividing it into <div>s. This structure would be more correct, as the current code makes the elements seem unrelated. Additionally, the appropriate tag for containing images is <figure>.
    • For the footers, it might be a good idea to group all elements into a single <section>, although I understand the reasoning for keeping them separate.

    Final thoughts: Despite these suggestions, your solution is visually very similar to the provided design. Congratulations on the great work!

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub