Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted over 3 years ago

Mobile first , responsive design using css grid and flexbox

itcss
Ejerson adarlo Beloso•50
@ejbeloso
A solution to the Fylo landing page with two column layout challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


Feel free to send your feedback. It will help me to improve and to code more. thanks

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Jannie Hansen•110
    @Jawha3
    Posted over 3 years ago

    Hey @ejbeloso, great effort!

    There's a few things that stand out to me when looking at your solution that I think you could work on to at least improve the next solutions you build.

    The overall layout itself is pretty much identical to the mockup (design) with the two columns, however the margins are too small which makes it look more off compared to the mockup. When you don't have access to the mockup it can be tricky to get the right margin and whatnot but I'm certain you can train your eyes to get close enough to the design.

    There's also a few other things that stood out to me - the font color in the CTA and Footer sections are grey rather than white and the font sizes are slightly off as well - this of course being something you will train your eyes to notice over time.

    Looking at the code I'd suggest looking into HTML Semantics to avoid having a million <div> tags.

    If you are serious about getting better at frontend I strongly suggest becoming Premium to get access to the mockups - it helped me a great deal.

    Keep up the great work!

    EDIT: I also just noticed you didn't add the social media links ;)

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub