Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted about 4 years ago

Mobile first | Responsive | Flexbox | Html y Css

rodrigo•40
@sstepaa
A solution to the 3-column preview card component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


Es mi segunda practica html y css , tratando de respetar una estructura semanticamente correcta , y utilizando metodologia ben en css , y medias query en una misma hoja de estilos , si hay algun error , con gusto quiero saberlo asi , voy aprendiendo mas :)

Code
Couldn’t fetch repository

Please log in to post a comment

Log in with GitHub

Community feedback

  • Gabriel Monsalve•320
    @Gabrieldev-web-coder
    Posted about 4 years ago

    Hola hermano, espero estés bien, aquí mi aporte.

    Solo decirte que te apegues a como esta hecho el diseño, hasta en lo más mínimo, esa es la gracia del frontend, efecto de hover y pudiste usar un cursor:pointer; en los botones, por que son elementos interactivos.

    Noté que para alinear el componente usaste margin y padding, y eso esta bien para algunas cosas, para el layout es mejor usar flex o grid, por ejemplo, en el elemento body o la etiqueta contenedora de tu contenido principal pudiste usar flex y justify content para centrarlo o usar unidades de viewport. En cambio el margin y el padding pudo servir bien para los elementos de las cartas, para el parrafo, las imagenes y los botones.

    Aún así luce bastante bien, sigue estudiando y practicando, sobre responsive design y las bases de css, ten buen dia.

  • Marcos Travaglini•6,210
    @Blackpachamame
    Posted about 4 years ago

    Buenas Rodrigo, te quedo muy bueno y solo puedo nombrarte algunos detalles.

    La etiqueta section es algo mas general, para dividir algo en diferentes temas, por ejemplo todas esas columnas juntas podrían ir dentro de un section. En este caso hubiera sido mas acertado colocar la etiqueta article.

    También podrías envolver todos esos section (article) dentro de un div/section y colocarle al main margenes para que las columnas no te queden pegadas a los bordes de la pantalla.

    Finalmente, al pasar los colores a hexadecimal se pierde la transparencia que necesitas en algunos casos.

    ¡Saludos!

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub