Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Mobile first single-price-grid

@Willarry

Desktop design screenshot for the Single price grid component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


My first frontend mentor challenge, any feedback would be appreciated

Community feedback

@afgalvan

Posted

It's pretty accurate, but you could import the font-family from google fonts here https://fonts.google.com/specimen/Karla?query=karla.

Also, the border-radius could be easily done by: .flex-left { border-radius: 0 0 8px; }

.flex-right { border-radius: 0 0 8px; }

And the last tip, try respecting the HTML indentation you use.

1

@Willarry

Posted

@afgalvan Thanks for your feedback, will look into it.

0
Szymon Rojek 4,540

@SzymonRojek

Posted

Hi William,

Well done :D

I have checked your HTML structure, a few tips from me:

  • instead of <div class="container"> you can use the section tag;
  • this is a single page component so you can add h1 tag;
  • in the second card you can use p tag with two spans inside for the price and per month;
  • don't use ID's (you will use them with JS);
  • what do you think about link instead of a button?
  • please use a proper spacing in your HTML structure because at the moment it is quite difficult to read;
  • removing the outline from a button it is a bad practice (accessibility matter);

@afgaIvan mentioned already: try to use proper font, add border radius. Also check your project by the inspector in your browser on different devices (especially on mobiles => fix margin).

That's it from me. Ps. Don't forget to upvote any comments on here that you find helpful.

Greetings :D

0

@Willarry

Posted

@SzymonRojek Thank you for taking time to check out my code, I have made some changes.

0
Szymon Rojek 4,540

@SzymonRojek

Posted

@Willarry

I am glad your like it :D

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord