@vanzasetia
Posted
👋Hi renko!
🎉 Congratulations on finishing your first challenge! I hope that you enjoy and learn something new when building this project.
For the plan-card
layout, I was making the plan-card
as a flexbox container. I didn't use justify-content: space-between
, because it didn't work for me. So, I used margin
on the plan-info
to control the spacing. You can check my solution for this challenge, if you really want to understand how I did it.
For the feedback:
- The card is touching the bottom of the page. You can add
padding-bottom
to thebody
element to prevent that. - In this case, all images are decorative only, meaning that you can just leave the
alt=""
and addaria-hidden="true"
orrole="presentation"
to make sure all screen reader will ignore those images. - You need to wrap all your page content with
main
tag. This should fix the accessibility issue that you currently have. - The card description is too narrow on mobile view, try to reduce the
padding
of it. - Try to match the color as the design image.
That's it! Hopefully this is helpful!
Marked as helpful
@renko7
Posted
@vanzasetia Thank you! Will work on these changes ASAP!