Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Mobile first site using sass

renko7• 50

@renko7

Desktop design screenshot for the Order summary component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Hello!! Thanks for checking out my website, I was hoping to get some feedback as this is the first time I am properly sending out a project and would really appreciate any suggestions.

I just had one problem that I was not able to move the price information right next to the image. The most advanced idea that I tried was taking the music icon out of a flexbox completely, and just having the price info and the change link in one flex and they would get justify-content: space-between. However this did not work as it was not able to use much of the space to the left.

Community feedback

Vanza Setia• 27,855

@vanzasetia

Posted

👋Hi renko!

🎉 Congratulations on finishing your first challenge! I hope that you enjoy and learn something new when building this project.

For the plan-card layout, I was making the plan-card as a flexbox container. I didn't use justify-content: space-between, because it didn't work for me. So, I used margin on the plan-info to control the spacing. You can check my solution for this challenge, if you really want to understand how I did it.

For the feedback:

  • The card is touching the bottom of the page. You can add padding-bottom to the body element to prevent that.
  • In this case, all images are decorative only, meaning that you can just leave the alt="" and add aria-hidden="true" or role="presentation" to make sure all screen reader will ignore those images.
  • You need to wrap all your page content with main tag. This should fix the accessibility issue that you currently have.
  • The card description is too narrow on mobile view, try to reduce the padding of it.
  • Try to match the color as the design image.

That's it! Hopefully this is helpful!

Marked as helpful

0

renko7• 50

@renko7

Posted

@vanzasetia Thank you! Will work on these changes ASAP!

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord