Skip to content
Submitted about 4 years ago

mobile first site with bem and scss and javascript nav

Heritier Akilimali•310
@heritio
A solution to the Blogr landing page challenge
Preview (opens in new tab)Code (opens in new tab)

Solution retrospective

Thanks for anyfeedback, If you have any recomendantions on how to abstract the nav javascript more, would be good for advice. And do you recommend to use different classes for javascript than css or just use the same, when selecting them.

Thanks for your time.

Code

Please log in to post a comment

Log in

Community feedback

  • P
    j5•2,270
    @jmnyarega

    Hi @heritio, nice work on the challenge I have few suggestions.

    • If you are using BEM, you can not nest elements.
    • Prefer using relative units[ ems, rems] to pixels em-vs-rem-vs-px
    • It is advised not to use solid widths & heights, use max-width instead.
    • Feel free to use multiple media queries to adjust background images on different screen sizes.
    • Use max-width on text content to avoid text overstretching on big screen sizes.
    • Spacing between sections doesn't look proportional, You may want to use the same value.
    • You can use align-items: center, to place text content & images side by side.

    Otherwise, this was an impressive effort. Happy coding!

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord