@pikapikamart
Posted
Hey, awesome work on this one. Layout in desktop looks great, it is somehow responsive but when it occurs on the mobile breakpoint, the image is not occupying the whole width of the container.
Some suggestions on the site would be:
- Always have a
main
element to wrap the main content of your page. On this one, the.container
should be using themain
instead ofdiv
. - The
.attribution
should befooter
so that it is contained inside a landmark element as well. - On the
li
tag, don't just usespan
to wrap those text, use a meaningful element likep
tag on it. - Lastly, just adjusting the
img
to occupy full width on a mobile breakpoint.
Just those only, actually the markup seems great, just missing some elements. Aside from those, great job again on this one.
Marked as helpful