mobile first using Flexbox

Community feedback

• 

  Vanza Setia•27,715

  @vanzasetia

  Posted almost 4 years ago

  👋Hi Haydn Kerr! My name is Vanza!

  It seems like this project is not finished yet and also have a lot of issues. Try to fix those issues as soon as you can.

  For the icon you can download it from icomoon or you use font awesome.

  If you choose font awesome, you can put this link inside your head tag rather than create an account on font awesome.

  <link rel="stylesheet" href="https://cdnjs.cloudflare.com/ajax/libs/font-awesome/5.15.3/css/all.min.css" integrity="sha512-iBBXm8fW90+nuLcSKlbmrPcLa0OT92xO1BIsZ+ywDWZCvqsWgccV3gFoRBv0z+8dLJgyAHIhR35VZc2oM/gI1w==" crossorigin="anonymous" referrerpolicy="no-referrer" />
  

  I have some feedback for this project:

  • You can use nav tag instead of div with the class of nav.
  • You can use section tag for each section rather than using a div.
  • The img tag must have alt attribute. But, you can leave it empty like this alt="".
  • Only use one h1 at a time since h1 is a call to action for every page.
  • Anchor tag also must have href attribute and you can't leave it empty like alt. But, you can do this instead href="#".
  • My recommendation to this project is that, try to do it slowly. There's no time limit so feel free to take as much time as you need.
  • Instead of use width: 90%, you can use padding-left and padding-right to prevent it touching the corner of the screen.
  • Use rem units instead of px, since rem will allow the use to change the font size based on their browser setting.

  I know it may be kinda overwhelming, but as the time goes on, you will get better. Just be patient!

  That's it! Hopefully this is helpful!

  00

  Marked as helpful
• 

  Mojtaba Mosavi•3,740

  @MojtabaMosavi

  Posted almost 4 years ago

  I usually use font-awesome for icons but you can also make you're own icons.

  Keep coding :)

  00