Hi
The only real problems I see here are that you can't have multiple h1s on a page, only one. And font size must never be in pixels.
Other than that, all is fine but the sizes aren't quite matching up to the design so maybe see if you can tweak little bits to get it closer.
I'd also recommend thinking about class and variable naming a bit more... They're fine. They work. But they are very related to the content at the moment. You could name things in a more generic way... But naming is always difficult and some of that comes naturally with time so don't worry too much about it. I'm just mentioning as something you might want to think about / read about.
Best wishes to you
@gfontorbe
Posted
Hi Grace,
Thanks for the comments.
I'll open a thread on the #best-practices channel when I get a bit of time. I keep reading contradictory information about the multiple h1 problems. We can discuss that there. I'll share links and open questions.
Noted for the font sizes, I thought I had everything on rem. I'll check that.
I'll have a look at others' naming styles for classes and get some reading done!
Cheers
@gfontorbe I'm surprised you've ever heard a debate on multiple h1s, that's been an established standard for a long time. It doesn't hurt google SEO like it used to, but can make things difficult for assistive tech, meta data and other search engines
