Mobile first using HTML, VanillaJS, CSS.

Community feedback

• 

  Agata Liberska•4,075

  @AgataLiberska

  Posted almost 4 years ago

  Hi @gtw1986, nice work here :) Here's some things that could use work:

  • as for the accessibility, you could definitely swap the divs with the class of 'button' for actual button elements.

  Some usability issues:

  • Sometimes I seem to be able to have two or three buttons have the class 'active'. Could be because you're listening to the event on the entire node list rather than individual buttons? Not sure. Anyway, what I would do is on click I would remove the active class from all of the buttons and then add it to event.target.

  • I do get a warning that I can't have number of people set to 0 but I can go below 0. You can use min attribute on your input to fix that :)

  • When I input the amount to pay and select tip value, the amounts get calculated fine, but when I change the number of people, the calculated amounts disappear and I have to click on tip % to calculate again.

  • And lastly, you can use .toFixed() function to format the result, I don't think we need to see more than two decimal points :)

  Hope this helps, if you have any questions, let me know!

  Happy coding :)

  21

  Marked as helpful