Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Mobile first workflow using CSS Grid

CodingDuck 390

@KaskaS-O

Desktop design screenshot for the Social proof section coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Hi!

Any feedback will be great! :) I had one small problem - it seems that row gaps make the content overflow grid-container. Changing grid-template-row from auto to 1fr or anything else wouldn't fix it. I tried setting min-height too but no success. Any ideas? Thanks for help!

Kaska

Community feedback

@gchristofferson

Posted

Hey @KaskaS-O ✋

Great job, it looks really good!!

I looked at your code and the reason your testimonial boxes are overflowing the grid-container is because of transform: translateY(10%) on your .opinions:nth-child(2) and transform: translateY(%20) on your .opinions:nth-child(3).

Instead try selecting .opinions:nth-child(1) and setting `transform: translateY(-20%)'

Then select .opinions:nth-child(2) and set transform: translateY(-10%). Then adjust your row-gap accordingly. This way you are moving the elements inside the grid and not outside of it. Let me know if that works for you.

Marked as helpful

1

CodingDuck 390

@KaskaS-O

Posted

@gchristofferson Hi!

Thanks for advice! It helped... sort of ;) Solved the problem in desktop layout, but it's still present in mobile vesion although there's no transform used for positioning. Do you have any idea about that?

0

@gchristofferson

Posted

Hi @KaskaS-O 🙋‍♂️

Now it's perfect! 👍 I personally didn't see any issues with the mobile version. Great job!

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord