@DEmanderbag
Posted
Nice work with the design and the code overall. I really like the use of BEM classes for this project.
The reason why the website is not aligning vertically is because the page is not full screen. If you check your solution in a web browser and hover over a body (or put background color on a body) element you can see that it's not a full page. To resolve that issue, you can put a min-height of 100vh on a body element.
In your case, you can set min-height on a class "container" and because you are already using a grid you can just use also place-items: center;
to align items horizontally and vertically.
This next suggestion is more for git and GitHub in general than for this project but I think it will be helpful.
I would also like to suggest that you put some context on your commit messages or at least what did you change on that commit. Instead of "commit update 8" you can write something like "update cards alignment", or "If applied, this commit will update getting started documentation"
For git messages, I would suggest this article: "How to Write a Git Commit Message - Chris Beams".
One last thing is to check again the email on Git and GitHub because looks like they are different and because of that on your GitHub it's only showing one contribution instead of 9 for today
@chiptaylor
Posted
@DEmanderbag Thank you for the comments. They are very helpful. I am looking at modifying the vh settings to set a min-height to correct the alignment issues. The Git / Github tips are greatly appreciated. I found in my Git that the email was not set - so I set it and that should be resolved. Finally, thank you for suggesting the resource for Git Commit messages. This is excellent. Thank you again for helping me!
@DEmanderbag
Posted
@chiptaylor you're welcome it was my pleasure.
Keep on coding ^^