Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Mobile layout first, SCSS, BEM methodology

Khalis 135

@khalisabrahman

Desktop design screenshot for the Maker pre-launch landing page coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
2junior
View challenge

Design comparison


SolutionDesign

Solution retrospective


Any suggestions on ow I can improve the active states of the form section?

Community feedback

Khalis 135

@khalisabrahman

Posted

Thank you so much for taking the time to provide the feedback!

Will put in place the recommendations in the project.👍

1
MasterKrab 940

@MasterKrab

Posted

Great job on this challenge!

I have a couple of recommendations:

  • The input should have a valid accessibility name, such as a label with a for attribute or an aria-label. Also since it is a field for the email it should have type="email".
<label for="email">Email</label>
<input type="email" id="email">

<-- Or --->

<input type="email" aria-label="email">
  • The section and article should have a title (h1-h6), or you can use an aria-label as well.
<article>
 <h2>Title</h2>
 <p>Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. </p>
</article>

<-- Or -->

<article aria-label="Title">
 <p>Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. </p>
</article>
0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord