@tmerrick17
Posted
Thanks for the comments. I really appreciate the feedback.
Things I fixed:
- I took out the alt attribute after reading this article to better understand what you were saying. https://supercooldesign.co.uk/blog/how-to-write-good-alt-text I appreciate this. I will do this going forward with more “decorative” images.
Things to (kindly) push back on:
- In the syle-guide.md file it specifies the desktop width to be 1440px on line 8. This is simply where I added the pattern-background-desktop.svg to the background. You are right though, I would have added the desktop background probably closer to 1200px but I want to be a precise as possible with the documentation. Thoughts on this?
Questions on:
- In the very beginning of you comments you mention “…background-wave is not really taking the whole width like it’s supposed to.”
Both mobile and desktop wave backgrounds go across my browser all the way. I’ve tested out on: Operating System macOS High Sierra Version 10.13.6 - Firefox 92.0 (works like the solution displays) - Chrome 93.0.4577.82 (works like the solution displays) - Safari 13.1.2 (wave background doesn’t show up at all…will check into this.)
What browser is this happening to on your end?
Most importantly I really do appreciate all the feedback. I’ve been coding for just about a year now and Frontend Mentor has already been a great find!