P
ApplePieGiraffe• 30,545
@ApplePieGiraffe
Posted
Greetings, Oluwatosin Abigail Ogundeji! 👋
Good effort on this challenge! 👍
Here are a few things I'd like to suggest,
- Perhaps making the elements that trigger the dropdown menus with more options in the header of the site buttons instead of links (since when they are clicked on, they do not take you anywhere yet, they simply display a menu).
- As you mentioned, making sure to always wrap
lielements in aulelement (not another element like adiv, which will give you a warning for having invalid markup). - Maybe wrapping each button in the header of the site in a container with its associated popup menu. That will group them together in your code and may make it easier to style. 😉
- Looking into using the
aria-controlsattribute on those buttons to show what areas/elements of the markup they control or affect. Learn more about that here. 😀
Hope you find these tips helpful. 😊
Keep coding (and happy coding, too)! 😁
Marked as helpful
1
@Heph-zibah
Posted
@ApplePieGiraffe
Wow. You even included a link.
Thank you for taking out time to review the project. I will make sure to work on the suggestions giben.
I apologise for replying this late.
1
P
ApplePieGiraffe• 30,545
@ApplePieGiraffe
Posted
@Heph-zibah
No problem! 😉
0
