Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted over 2 years ago

Mobile-first approach using SCSS, BEM and simple hamburger menu

accessibility, bem, sass/scss
Patryk Porabik•80
@PatrykPorabik
A solution to the News homepage challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


I will probably make some fixes to the project, but I decided to push it to the review. So far, the most tricky part was to handle menu. I've tried to work on the same nav elements on every device, however I was struggling with its appearance. I decided to make two independent elements, but I know that it may not be the best solution in the bigger projects. This part has potential to be improved.

Same with the sidebar menu, I've made it, however I don't like the behavior that on reload, we can see the transforming (translateX) element. It should be hidden from the beginning.

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Matheus Viana de Souza•20
    @vianaV19
    Posted over 2 years ago

    Hello Patryck, Nice to meet you,

    I've seeing your solution and I noticed that the last list of elements are overflowing the page width. You can create a class called container defining the width and set it up in each webpage section.

    This is my solution in the case you want to see and do a constructive criticism. Thank you!.

    Github news-homepage solution: https://github.com/vianaV19/news-homepage Link to solution website: https://news-homepage-murex.vercel.app/

    Greetings!, Have a nice day!.

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub