@pranshudobhal
Posted
Hi Shivam,
I looked at your code and it looks pretty good. I have a few suggestions.
-
When viewing the website in mobile size, the "Reliable, efficient delivery" and "powered by technology" look big on mobile devices. I see that on the mobile device, the font-size that is being applied to the headings is 2rem. If you change the value to 1.5rem, it looks much better and closer to the design provided.
-
I saw that you defined font-size 100%. I don't know what your default font values are in Chrome. But in general, the default values for chrome is 16px. So, when you write 100%, the value is set to 16px. But as mentioned in the design, the value should be 15px.
-
For responsiveness, the way I've implemented it is using Bootstrap 4 as it uses flexbox now instead of float and positioning. So, it is much easier and convenient to position and align the items individually. And Bootstrap is great for responsiveness as well. So, it
I would love it if you could review my solution and let me know the areas where I can improve. Thanks!
@shivjoshi1996
Posted
@pranshudobhal Hey there, thanks for the feedback. I'll definitely take it on-board. I'll check out your code now :)