Good job on this!
Only a few minor suggestions
- on suvs alt text you need to capitalise SUV so screenreaders can read it out properly
- the buttons in this should almost certainly be anchor tags as it's most likely they would navigate somewhere
- remember to add focus-visible styles to interactive elements as well as hover
Well done again
Marked as helpful
@newlomar
Posted
@grace-snow Hi Grace!
Thanks a lot for the help again! Also for the motivation :)
I made the corrections and I think I got it for the first and second suggestions that you made, but for the third one I am in doubt, because I never worked with focus-visible styles before.
If you have some time, can you check if that propertys that I added for focus-visible are what you expected?
Thanks a lot again.
@NewLomar I can’t check tonight as I’m on my phone not keyboard atm.
But I can see one big issue now - it’s invalid to have button elements inside anchor tags or vise-versa. They are completely different elements semantically. You need to remove the buttons on this
Focus-visible styles are for keyboard tabbing. It should be really obvious where you are on a page when using keyboard. Usually this is done with a bold outline.
@newlomar
Posted
@grace-snow Ok!
Thanks again, grace!
@newlomar
Posted
@grace-snow I finally understood the focus better and I think that now its making sense.
I also made the buttons inside a tags corrections.
Thanks a lot, Grace!
