Skip to content
Submitted about 2 years ago

Mobile-first solution using CSS Grid and Flexbox

bem, sass/scss
Oleksandra•40
@OlSerkes
A solution to the News homepage challenge
Preview (opens in new tab)Code (opens in new tab)

Solution retrospective

I would like to get feedback about my solution on media-queries because I don't have experience in mobile-first solution. And I just started to learn CSS animation and it would be great to hear some advices or recommendation in my solution for modal window.

Code
Loading...

Please log in to post a comment

Log in

Community feedback

  • Mukwende•1,370
    @mukwende2000

    The solution you provided is just fine, for the js, i would give the functions a more descriptive name. Instead of just open, let it be openModal and closeModal for the other one. Then the buttons will be openModalBtn and closeModalBtn respectively.

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord