Mobile-first solution using Flexbox and BEM

Solution retrospective
Hey guys and gals! I'd very much appreciate if you would take the time to review my code :) please tell me how I can improve! I want to learn more about best practices and I would want my foundations to be solid. Thanks!!
Please log in to post a comment
Log in with GitHubCommunity feedback
- @ApplePieGiraffe
Hey, Alphonzo Escolar! 👋
Just wanted to say, good work on this challenge! 👍 Everything looks pretty great and the card component responds nicely! 🙌
You can style the focused state of the link using the
:focus
selector, but there's actually already an outline that appears when the link is focused, so I think it's fine (unless you want to style the outline differently or something). 😉Keep coding (and happy coding, too)! 😁
- @SzymonRojek
Hi phonzdev,
Well done :D
I have checked mainly your HTML, a few tips below:**
- instead of div class="container" you can take the main tag;
- in my opinion we don't have to use ul>li in the second box: h2 and two paragraphs will be ok;
- add focus to a link;
- check a project in your browser by using the inspector on different devices (especially mobiles) => there is a problem with the link;
Ps. Don't forget to upvote any comments on here that you find helpful.
Greetings :D
- @phonzdev
Thanks @SzymonRojek for your feedback! :) With regards to adding focus to a link, do you mean the pseudo selector?
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord