Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Mobile-first solution using Flexbox

SmritiP 20

@Smritipradhan01

Desktop design screenshot for the NFT preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Hey everybody, please review and provide your feedback on the accessibility, responsiveness or the structure of the code overall. Thanks!

Community feedback

Mo 840

@MohamedAridah

Posted

Hello @Smritipradhan01, You did a good job for this challenge🎉👏👍.

There are my notes for your project:

  • From the first look it was obvious that box-shadow was too much. So try reduce it little bit.
.card-container {
	box-shadow: 1px 5px 15px 2px rgb(20 37 61 / 30%);
	/* Always with box-shadow use alpha channel with low opacity */
}
  • use transition property for .card_attribution span for smoother color shifting.

  • You solution is Responsive and this is good.

HTML Structure

  • instead of the the current html structure. you can use more simple one:

    • the card consists of 3 main <div>s
      • <div> for the card image
      • <div>for the card details
        • <div> for details text
        • <div> for the statistics below it
      • <div>for the card footer
  • you can get rid of .card_img-overlay-container and use pseudo elements like ::after or ::before for the .card-image-container. ex:

.card_img-container::after {
	content: url(./images/icon-view.svg);
	position: absolute;
	background-color: var(--cyan-overlay);
	width: 100%;
	height: 100%;
	opacity: 0;
	top: 0;
	left: 0;
	display: flex;
	align-items: center;
	justify-content: center;
	cursor: pointer;
	border-radius: 1rem;
	overflow: hidden;
	transition: .3s ease;
}
.card_img-container:hover::after {
	opacity: 1;
}
  • instead of using <hr> element as border between divs you cab use border-top or border-bottom properties depending on the suitable situation.

  • you can see My solution for this challenge it may be useful for you.!

I hope this wasn't too long for you, hoping also it was useful😍.

Goodbye and have a nice day.

Keep coding🚀

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord