@vanzasetia
Posted
Hi, Simon! ๐
Congratulations on finishing this challenge! ๐ I hope that you are still online at Frontend Mentor.
It's great that there's a scrolling animation and in my opinion, it would be better if the users that don't want to see animations can turn off the scrolling animation. You can use prefers-reduced-motion
media query to turn off the animation.
I have some feedback on this solution.
- Alternative text shouldn't contain any words that are related to the word "image" (e.g. logo).
- Any interactive elements such as buttons should have an accessible name or label. Otherwise, the screen readers don't know how to pronounce it.
- Avoid using
br
elements for presentational purposes. Read the "Accessibility concerns" part of the MDN documentation forbr
. - Wrap the quoted content with
p
.blockquote
elementโs content is a quote, not a chunks of characters. Reference: hail2u/html-best-practices #use-appropriate-element-in-blockquote-element - Use the
em
unit for media queries. It adapts when the users change their font size setting. Here are some references. - Never set
font-size
on thehtml
element. It will overwrite the user's browser's font size setting. input
elements must have a label. I recommend usingaria-label
to give each of theinput
an accessible name.
I have three recommended videos. The first one tells how hard HTML is (HTML is not easy). The other two talk about modern CSS techniques and approaches.
- Manuel Matuzoviฤ - Lost in Translation - YouTube
- Andy Bell โ Be the browserโs mentor, not its micromanager - YouTube
- Stephanie Eeckles - Scaling CSS Layout Beyond Pixels - YouTube
I hope this helps! Happy coding!
Marked as helpful