Skip to content
Submitted over 4 years ago

Mobile-first webpage built with HTML, Sass, and JS

Rabin Gharti Magar•455
@Rabin92
A solution to the Digital bank landing page challenge
Preview (opens in new tab)Code (opens in new tab)

Solution retrospective

I have finally completed this challenge!!

I found the hero section very challenging however I somehow managed to fix it by doing some research and watching a few tutorials. This challenge really tested out my layout skills and I am very glad that I got to learn new techniques and acquire new knowledge which I was not aware of.

Any feedback regarding my solution and my code would be greatly appreciated!

Code

Please log in to post a comment

Log in

Community feedback

  • Tesla_Ambassador•3,070
    @tesla-ambassador

    I really like what you did with this challenge my favorite bit is the way you used the opacity on the pictures in the "Latest Article" section

  • P
    The Burrito Doggie•1,260
    @BurritoDoggie

    hello Rabin Gharti Magar,

    I really think it is fantastic. It actually looks like it would be from Github. I can't really correct you on anything since I am definitely not as good as you. I just wanted to say that it is really cool.

    Keep Coding!

                                         (@@)
                                      \__/
  • ApplePieGiraffe•30,525
    @ApplePieGiraffe

    Hi, Rabin Gharti Magar! 👋

    Well done on this challenge! 👍 Your solution looks great and responds very well! 👏

    A tiny thing I might suggest is replacing the hamburger menu icon with an "X" icon when the menu is open. I think might be a nice extra touch! 😉

    Keep coding (and happy coding, too)! 😁

  • brigittavarga•55
    @brigittavarga

    Nice job on this one, looks great! I am currently working on this challenge, going to add extra pages to it for practice with my designs. Going to share the result soon!

  • Anna Leigh•5,135
    @brasspetals

    Hi, Rabin! 👋

    Excellent job on this solution! 🎉 It responds very well, and looks great on large screens (1920px) too! Your work on the hero images paid off. What were the new techniques you learned on this project?

    You really did a good job here, and I could only find a few, small suggestions:

    • Adding object-fit: cover to your .article__image will allow the image to fill the height and width while maintaining its original aspect ratio - right now the images can get a little bit distorted.
    • You might change the footer layout switch to a little later/wider. At around 685px it feels very squished.

    Happy coding!

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord