Multi step form built with React, Typescript and CSS modules

Solution retrospective
I have an Input component that render the form in the personal info step number 1 it's working just fine but I would appreciate any feedback on it because I feel like it's a bit cumbersome and I think I need to refactor it. thanks in advance
Please log in to post a comment
Log in with GitHubCommunity feedback
- P@de-furkan
I love it great effort, lovely design🎉🎉
In terms of key areas for improvement:
- avoid setting:
outline: none;
-
i understand this can be tempting to do this, as the default outline usually looks ugly, but it can cause accessibility problems for users that make use of accessibility features. Outline is an important part of the accessibility tree to help users navigate and see selected areas of the form
- while this can be overcome with other ways of styling, as you have done here, but it is still recommended to keep the outline.
-
perhaps as an alternative, you could style the outline as needed instead of adding an additional boarder
-
make use of <main> element to place the content into the main block
- this makes it easier to control layout and page size as demonstrated in this code:
<main> // Html or react codes in between </main> html, body{ height: 100%; } main{ min-height: 100%; }
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord