Design comparison
Reports
Constantineβs questions for the community
i know i know... i need to improve Js and CSS
Community feedback
@0xAbdulKhalid
Posted
Hello there π. Congratulations on successfully completing the challenge! π
- I have other recommendations regarding your code that I believe will be of great interest to you.
HEADINGS β οΈ:
- This solution had generated accessibility error report due to lack of level-one heading
<h1>
- Every site must want at least one
h1
element identifying and describing the main content of the page.
- An
h1
heading provides an important navigation point for users of assistive technologies, allowing them to easily find the main content of the page.
- So we want to add a level-one heading to improve accessibility by reading aloud the heading by screen readers, you can achieve this by adding a
sr-only
class to hide it from visual users (it will be useful for visually impaired users)
CSS π¨:
- Looks like you already the centered the component, but the issue is the
height: -webkit-fill-available;
is not an appropriate way to applyheight
to body element. So apply the following css rule to center the component accurately
body {
min-height: 100vh;
}
.
I hope you find this helpful π Above all, the solution you submitted is great !
Happy coding!
Marked as helpful
@CONSTANTlNE
Posted
@0xAbdulKhalid this webkit is nonsense... have to find some other way, thanks
@Fredeugine
Posted
The change button at the final screen where there is a submit button is not working. Great work Dude
Marked as helpful
@CONSTANTlNE
Posted
@Fredeugine yeah thanks, i missed couple things, didnt include 2 months discount as well.. just missed
Please log in to post a comment
Log in with GitHubJoin our Slack community
Join over 180,000 people taking the challenges, talking about their code, helping each other, and chatting about all things front-end!