@brasspetals
Posted
Hi, David! Congrats on completing another solution! đ
Overall, you did a good job, and it responds very nicely. My only suggestion on that front is to add a max-width
to your cards container for mobile styling, as the cards tend to get pretty stretched between about 500px-700px. Having them match closer in width to the heading text would look nicer.
To clear up your accessibility errors:
- For âDocument should have one main landmarkâ, use a
main
element to wrap the content of your page, and apply your position styling (padding, margin, display, etc.) to that rather than directly on the body. This will hopefully also clear up the other âlandmarkâ errors in the report - not entirely sure as Iâm not familiar with the new report system yet. đ€ - For âPage should contain a level-one headingâ, I suggest wrapping both of your headings in the
.heading-section
in a single h1 tag (rather than an h3 and h2) with aspan
around âpowered by technologyâ in order to apply the bolder styles. You can control the line break through setting awidth
ormax-width
withch
units.
Hope my suggestions help! Happy coding! đ
Marked as helpful
@hmadamk
Posted
@brasspetals yeah the cards is stretching to much