My first project at Frontendmentor.io Qr code

Community feedback

• Account deletedPosted over 2 years ago

  Congratulation on completing the challenge.

  I will go through some of the issues that I can see. It is essential that you use semantic HTML. Landmarks such as <header>, <main>, <nav> and <footer> aid navigation in assistive technologies such as screen readers. So instead of using <div> for your container use <main> and for your attribution change to <footer>.

  Page headers always start at <h1> and subsequent headers cannot skip the header order meaning you cannot go from say a <h1> to a <h3>.

  to check if your markup is correct before uploading use this html validator

  Also start saving your css in a separate file and link it to your markup.

  otherwise great job.

  00

  Marked as helpful
• 

  Jakub Jirous•270

  @jakubjirous

  Posted over 2 years ago

  Hi, It's obvious that you have a good understanding of the problem and have worked hard to find a solution. I greatly appreciate the effort you have put into providing this solution; your code is clear and easy to understand, and your logic is sound.

  To make your code even more readable and maintainable, I would recommend using a tool that facilitates code formatting. Despite the fact that your current formatting is adequate, using a code formatter will help others understand and read your code more easily, especially if you are part of a team.

  Using tools such as Prettier, you can automatically format your code according to a set of rules, ensuring consistency and readability across your project.

  Overall, great job on the solution, and I encourage you to consider using a code formatter to make your code even better!

  Cheers, Jakub

  00

  Marked as helpful