My First QR-Code Card

Community feedback

• 

  Aakash Verma•9,520

  @skyv26

  Posted 7 months ago

  @MarziaJalili

  Explain why ?

  First, using px for the font-size happens to cause some issues. I suggest you use rem units instead.

  12
• 

  Marzia Jalili•9,670

  @MarziaJalili

  Posted 7 months ago

  Congrates buddy,

  Some tips for you to consider in your next projects:

  • First, using px for the font-size happens to cause some issues. I suggest you use rem units instead.

  • Second, using grid to center the card is much more consice:

  .container {
    display: grid;
    place-items: center;
  }
  

  • Also, avoid using a fixed height (line 14 in style.css).

  This may not make anything go wrong in this challenge 'cause there's only one card and the screen doesn't get larger then 100%, but in others that do get larger it's going to be an issue, man.

  Instead you can use min-height: 100vh.

  Other than this your web looks AWESOME 😎

  keep up the great work 💪

  00