@ApplePieGiraffe
Posted
Hi there, Bonrey! π
Well done on this challenge! π And kudos for trying out React! π File structuring was something I was rather confused about, too, when I first tried out React, but I think it becomes easier to understand with practice, of course! π
The text in your solution becomes very, very small when the screen width decreases in the desktop layout. I suggest setting your font-sizes in em or rem so that the size of the text remains more consistent across screen sizes and is more accessible and predictable than setting font-sizes in viewport units.
Also, if an invalid email is entered into the input and submitted, the value of the input element changes to "[email protected]." I think it would be better if the value of the input remains the same as what the user typed so that they don't get confused and have to delete the replaced text. π
Keep coding (and happy coding, too)! π
@Bonrey
Posted
@ApplePieGiraffe thank you! I'll take into account your suggestions! Especially about the font-size.
As for the "[email protected]", I just followed the design patterns for this challenge. But I agree that it doesn't look good. Sometimes it's indeed better to come up with some features yourself than copy the default pattern π
@ApplePieGiraffe
Posted
@Bonrey
No problem! Glad to help! π
If you look closely at the design JGPs for this challenge, you'll notice that the value of the input element is actually "janeappleseed#gmail.com"βmeaning it's only an example of what an invalid email might be and of what the invalid state of the input element should look like. You don't actually have to change the value of the input element to something else for this challenge! π
@Bonrey
Posted
@ApplePieGiraffe hahah, got this π
