Skip to content
Submitted 10 months ago

My qr code component

Mongkolkhanit_d•20
@mongkolkhanit-d
A solution to the QR code component challenge
Preview (opens in new tab)Code (opens in new tab)

Solution retrospective

What are you most proud of, and what would you do differently next time?

I feel like I can do things more easily! Thanks to the people who helped guide me, I have read and tried to improve my skills.

Code

Please log in to post a comment

Log in

Community feedback

  • manamasu•10
    @manamasu

    I have reviewed the source code a little and would like to suggest a few potential improvements regarding property sizes. For instance, in larger CSS files, it may be beneficial to avoid using specific values such as font-size: 0.938rem in the class card--name, as this could complicate maintenance and consistency across the project (unless we are aiming for pixel-perfect designs that necessitate such precision).

    Additionally, I believe that extending the length of the card slightly, as demonstrated in the proposed solution, along with reducing the box-shadow effect, could enhance the overall appearance.

    Overall, great job on the project!

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord