Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted over 1 year ago

My QR Code component solution

IAmOrale•60
@IAmOrale
A solution to the QR code component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


What are you most proud of, and what would you do differently next time?

I started learning HTML & CSS on my own not long ago, in preprations for a 4 month fullstack bootcamp starting soon. This is my 1st project here, I'm proud I was able to get it done, and that it looks pretty similar

What challenges did you encounter, and how did you overcome them?

It was pretty straight forward

What specific areas of your project would you like help with?

I think I'm lacking in the resposivness part of the project, would love to get some pointers threre, I'm assuming I should use some sort of @media, but I haven't really gotten to that part in my studies.

I'd also like to know if I have any lines of code which are redundant, so I can improve on slimming down my code (E.G - a few lines of code which can be replaced by just one that does the same thing)

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • amnesia2k•50
    @amnesia2k
    Posted about 1 year ago

    The code includes semantic html, it is accessible and i think i can do better

  • Saeed Bin Mizan•80
    @BluffSet7340
    Posted over 1 year ago

    Looking at the side by side comparison, your solution is basically perfect. Regarding the responsive touch, there's no need to add it as even when you trim the screen size to phone width your solution should fit well. But if you had to, maybe a media query that scales down the container that houses the qr code and text itself, possibly making it easier to scan?

  • enoxDev•40
    @enoxSutrisno
    Posted over 1 year ago

    good...

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub