@elaineleung
Posted
Hi Amaury, excellent work here, and I think you should be proud of yourself for all the learning you've done that allowed you to finally complete this project. I'm glad you picked things up from where you left off instead of getting discouraged and not finishing it; I also have the tendency to put things down for awhile and then revisit them later once I gain more skills.
One suggestion I have about your code is to refrain from mixing id selectors with class selectors in your CSS, especially since the names you've used are so similar to one another. You never know if you might run into specificity issues somewhere down the road where you have no idea why a certain style is applied or why you aren't able to change a style. Anyway, since you know BEM, you might want to consider learning Sass to write your CSS; you may find that it will greatly enhance your CSS writing experience.
Some quick feedback on your work: Some parts aren't displaying the font face in the design, like the paragraph text in section one. Also, about the note on the nav in the accessibility issues, since you have more than one nav, you might need an aria label in the nav to indicate which nav it is (something like <nav class="nav-header" aria-label="navigation-header">).
Once again, congrats on the work you put in here, and keep going!
Marked as helpful
