Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted over 2 years ago

My Solution for the QR Component Challenge

R Hayes•240
@ryanthayes
A solution to the QR code component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


I was able to practice using CSS Custom Properties and the GitHub workflow. Thanks to initial feedback I was able to improve my HTML semantically and come up with a proper solution to vertically align content.

Code
Loading...

Please log in to post a comment

Log in with GitHub

Community feedback

  • C H A R A N 🎯•2,670
    @0xabdul
    Posted over 2 years ago

    Hello Developer well congratulations on successfully completing the QR code component A Some suggestions for improve your code !

    • IN HTML 📃 :
    • LANDMARK 🚀
    • The main landmark should be a top-level landmark. When a page contains nested document and/or application roles (e.g. typically through the use of iframe and frame elements), each document or application role may have one main landmark. If a page includes more than one main landmark, each should have a unique label.
    • To Clear the Accessibility reports use the Semantic elements Or non - Semantic elements
    • Note This Elements are don't sikp
    • semantic elements : <aside> , <artical> , <main>, <header> ,<section><footer>, <form> ect..
    • non- semantic elements : <div> , <span> ect ...
    • for easy way to clear the Accessibility reports using non semantic elements Ex :
    <body>
    <div class="container" role="main">
    /html code goes here : 📃
    </div>
    </body>
    
    • Or
    • using semantic elements
    • Ex :
    <header>
    should be put heading or logo📸
    </header>
    <nav>
    //Links here
    </nav>
    <main>
    Main of the contents 📃
    </main>
    <footer>
    ©copy right  here📍
    </footer>
    
    • IN CSS 🎨 :
    • your qr code card component is not center align it shows bottom of the web page so fix the problem
    • Good Example :
    body {
    display:grid;
    place-items:center;
    margin:0;
    height:100vh;
    }
    
    • use the code in case for center aligning 🎯
    • I Hope you find the solution and it's useful comment for you your QR Code component project is Awesome Finnally Happy Coding Developer 😊
    Marked as helpful
  • R Hayes•240
    @ryanthayes
    Posted over 2 years ago

    Thank you @0xAbdul I updated my HTML so that my generic div container is now semantically correct as <main>. I was also able to center the main content properly using flex box by adding your CSS suggestions below to .container:

    margin:0; height:100vh;

  • Alam•30
    @abdullahalam123
    Posted over 2 years ago

    You just need to set body { display: flex; min-height : 100vh; } This would allow your content to be aligned at the center. Hope this helps (:

  • AliTheCoder123•70
    @AliTheCoder123
    Posted over 2 years ago

    add a <main> element in your solution

    change the div container to main element container

  • AliTheCoder123•70
    @AliTheCoder123
    Posted over 2 years ago

    it is already center what do you want to center

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub