Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted over 1 year ago

My version of the QR card

Gian Ramelb•190
@rame0033
A solution to the QR code component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


I recently finished my web development I course from my college so I tried the first time to use frontend mentor to keep me on track and practice what I've learned. I learned to use comment everytime on my code so that I keep track on which parts I've made and the use of modular scaling for texts instead of pixels.

I used also a CSS reset for this one since it made me comfortable to style freely and being more precise somehow with my spacing.

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Melvin Aguilar 🧑🏻‍💻•61,020
    @MelvinAguilar
    Posted over 1 year ago

    Hello there 👋. Good job on completing the challenge !

    I have only one suggestion about your code that might interest you.

    • You can use the following styles to center the element effectively using either of these two methods: For Grid:

      body {
        min-height: 100vh;
        display: grid;
        place-items: center;
        /* Additional styles if needed */
      }
      

      For Flexbox:

      body {
        min-height: 100vh;
        display: flex;
        flex-direction: column;
        justify-content: center;
        align-items: center;
        /* Additional styles if needed */
      }
      

      Later, you can remove this margin:

      main, footer {
        /* margin: 6vh auto; */
      }
      

    I hope you find it useful! 😄

    Happy coding

    Marked as helpful
  • P
    Daniel 🛸•44,810
    @danielmrz-dev
    Posted over 1 year ago

    Hello @rame0033!

    Your project looks great!

    I noticed that you used margin to place the card in the middle of the page. Here's a very efficient way to center the card:

    • You can apply this to the body (in order to work properly, you can't use position or margins):
    body {
        min-height: 100vh;
        display: flex;
        justify-content: center;
        align-items: center;
    }
    

    I hope it helps!

    Other than that, you did a great job!

    Marked as helpful
  • Gian Ramelb•190
    @rame0033
    Posted over 1 year ago

    Any feedback and suggestions will be highly appreciated. Thank you! :)

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub