@matt-o-west
Posted
Hello! Very nice solution, and impressive this is all vanilla JS. One item:
- The voting isn't quite working like it should, you can vote once, and presumably the counter should disable, but the user is able to vote again. The second vote increments/decrements by two instead of one, as well.
Overall great work!
@CodePapa360
Posted
@matt-o-west I intentionally made it in a way that a user can vote a comment once. If a user upvote first, then he can change mind to downvote again.
Yes, First vote increments one and second vote increments two. Because, for example, if a comment already has vote 6, first time you click+, it should increase one and output will be 7, and then if you decide to downvote that comment, it should decrease two, because it already had 6, so you need to decrease two. So the output will be 5.
Thank you by the way ☺️
@cjcrawford
Posted
@CodePapa360 interesting take on the 2nd vote! Your explanation makes a lot sense when you assume the user can only go up or down. In the situation where a misclick occurs, having the ability to undo and remain neutral feels better to me, but that is not an implementation issue as your solution actually makes the most sense by saving an extra click (if there was an "undo" vote ui element it would be the best ux pattern along with your solution as one click would always give the intended outcome).
Anyway, just wanted to say thanks for explaining your reasoning as I think I want to update my solution now to use this idea and after voting, turn the selected arrow into an undo button.
@CodePapa360
Posted
@cjcrawford Thank you!🙂 In the future, I might decide to implement the feature "ability to undu vote when a user misclick".😊👍
