Submitted over 4 years ago

Newbie profile card, used semantic HTML and BEM CSS

@AMLO-Bot

A solution to the Profile card component challenge

Solution retrospective

I would love having feedback about the implementation of BEM arquitecture for this project. I reaaly think there is a lot of space for improvement and Im just a newbie so I do not know really what Im doing. Appreciate in advance your comments

Code

Please log in to post a comment

Community feedback

Cedrick Garcia•905
@cedgarcia
Posted over 4 years ago
As a newbie, your code looks great. Try to minimize your usage of a double dash(--) in naming classes because it might make someone confuse, and your CSS code will look messier(especially if you will use variables in CSS). You can check my solution here: (https://cedgarcia-front-end-mentor-solutions.vercel.app/1_profile-card-component-main/index.html), GitHub repo(https://github.com/CedGarcia/FrontEndMentorSolutions/tree/master/1_profile-card-component-main). Overall Good Work
William Spanfelner•155
@Will-1-Am
Posted over 4 years ago
Nice work! Check out the report above for some easy fixes to the code. Keep on coding ;-)

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord