Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

NEWS HOMEPAGE 🎯 [ ACCESSIBLE - BEM - VANILLA CSS3 - ES6 ]

#accessibility

@0xabdulkhalid

Desktop design screenshot for the News homepage coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
2junior
View challenge

Design comparison


SolutionDesign

Solution retrospective


👾 Hello, Frontend Mentor Community,

This is my solution for the News Homepage.

  • Scored 97% on Google Pagespeed Insights! 🤩
  • Changed some of the font color's intentionally due to it's bad contrast which may affect accessibility 🙅🏻‍♂️
  • Custom navbar w/ scroll-in & scroll-out animation 🔥
  • Solution with 99.9% Percent Accuracy 🎯
  • Accessible hamburger menu w/ ES6 🍔
  • Minified the css files to improve site performance 🚀
  • Used Prettier code formatter to ensure unified code format ⚙️
  • Layout was built responsive via mobile first workflow approach 📲
  • Had a lots of fun while building this challenge ! 🤠
  • Feel free to leave any feedback and help me to improve my solution 💡

.

👨‍🔬 Follow me in my journey to finish all junior challenges to explore solutions with custom features and tweaks

Ill be happy to hear any feedback and advice !

Community feedback

@Namonaki0

Posted

Hi Adbul, it looks impressive.

Just one thing, like mentioned before the content is superimposing itself on the bottom of the page (desktop design) - talking about main__headline and main__recommended. Looking at it from a glance it looks like if you remove the grid-template and you define the height as max-content instead, then add a margin-bottom to the main__headline it should fix the issue.

Maybe by now you're already working on it.

Hope this helps.

Marked as helpful

1

@0xabdulkhalid

Posted

Glad to hear your feedback @Namonaki0, I will update my code as soon as possible.

And another thing is you can use backticks (`) for sharing/highlighting a code snippet.

For example, You can try to wrap the "main__headline" with backticks

`main__headline`

Result: main__headline

1
Omar 240

@omar-csdev

Posted

hi, I noticed that there are repsonsive issues on larger screens. Mainly the bottom half of the screen on full width 24 inch monitors.

2

@0xabdulkhalid

Posted

@iHesh84 Thank you for noticing the issue you're facing.

But I can't test my application unless you provide the resolution of your screen where you faced the issue.

Can you provide your device resolution ?

For Example: This Resolution 1440 x 900 is for standard HD Laptop Screen.

0
Omar 240

@omar-csdev

Posted

@0xAbdulKhalid

The monitor is 1920 x 1080. Of course while using Chrome I can't use the full height.

0
P
Bart 210

@barterkamp

Posted

@0xAbdulKhalid

I would suggest to wrap the entire page in a max-width wrapper of 1440px en the contentss itself in a container with a max-width of 1110px.

for instance:

body {
 height: 100%
}

.page-container {
  display: grid;
  place-content: center;
  max-width: 1440px
 min-height: 100%
(to center the container on the screen)
}

.content-container {
max-width: 1110px
margin: 0 auto (to center within the container above)

If you decide to go this way you should also tweak the paddings and margins of your header and main.

2

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord