๐Animated News homepage Bootstrap๐
Solution retrospective
Hi there๐โโ๏ธ i really enjoyed solving this feedback is welcome
Please log in to post a comment
Log in with GitHubCommunity feedback
- Account deleted
Hey there! ๐ Unfortunately, there are countless things that need to be improved that I would not expect at this challenge level...
For example:
- This should be a
headerelement and not adiv.
-
Company logo
altdescriptions should NEVER โ be "logo"; it should always state the company's name. -
Your nav button is inaccessible โ ๏ธ. This because you built it using a
div(<div class="open-nav-div">) when it should off been built using abutton.
- The list items inside the nav menu should be wrapped inside an
anchorelement in order for them to be interactive.
These are just a few things that need to be fixed... there are a whole lot more things that need improvement.
I strongly recommend checking out https://web.dev/learn/html/ to enhance your web development knowledge. This resource can be instrumental in helping you avoid the types of mistakes that may arise in your future projects.
Upon reviewing your profile, I've noticed that you appear to be rapidly tackling various challenges, with near-daily postings. It seems that your primary emphasis is on animation rather than the quality and accessibility of your code.
As a web developer, it's crucial to make quality code (error free, semantically correct, proper usage of elements, etc...) and accessibility your top priorities. These aspects are what distinguish an average developer from an outstanding one.
If you have any questions or need further clarification, feel free to reach out to me.
Happy Coding! ๐พ
Marked as helpful - This should be a
- @mesutabdiwahab
liked it, mate.
- @mihapehlic
Teach me Sensei!
- @Emperor-Shadow
Amazing as always
- @PartialTruss
fantastic๐๐๐๐๐๐
- @AcerNg548
Love the animation
What package did you use please?
- @saddamjon1
Hello, Saad Hisham, make it a little lower, the rest is great
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord