Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

News Homepage built with SASS and Vanilla JS

#sass/scss
Nathan Soussanaβ€’ 40

@nathansoussana

Desktop design screenshot for the News homepage coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
2junior
View challenge

Design comparison


SolutionDesign

Community feedback

@VCarames

Posted

Hey there! πŸ‘‹ Here are some suggestions to help improve your code:

  • The nav should be wrapped inside a header element and the logo should be outside of the nav.
  • The logo's alt tag should state that company's name.
  • For the nav button to be fully accessible and functional, it needs to be built with the button element and have aria-expended, aria-label and aria-control.
  • The <section class="hero"> should be an article element instead.
  • The h1 for this challenge is actually visually hidden while the "The Bright Future of Web 3.0?" is an h2 heading.
  • For your "Read More" button, you are nesting the anchor and button element; This is not allowed. You can only use one or the other. For this challenge, it will be the anchor element.
  • In <section class="new">, the articles should be built using an unordered list while the articles in the <section class="numbered"> will be ordered list.
  • The articles headings in the "new" and numbered sections should be h3 since it is not allowed to skip heading levels.
  • In the <section class="numbered"> there should be a visually hidden h2 heading.
  • Numbers are never headings.

If you have any questions or need further clarification, feel free to reach out to me.

Happy Coding! πŸ‘Ύ

Marked as helpful

1

Nathan Soussanaβ€’ 40

@nathansoussana

Posted

@vcarames thank you very much for your helpful and detailed review πŸ™

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord