γγ¬γ³γΏγ€γ³ πβ’ 64,250
@VCarames
Posted
Hey there! π Here are some suggestions to help improve your code:
- The
nav
should be wrapped inside aheader
element and the logo should be outside of thenav
.
- The logo's
alt
tag should state that company's name.
- For the nav button to be fully accessible and functional, it needs to be built with the
button
element and havearia-expended
,aria-label
andaria-control
.
- The
<section class="hero">
should be anarticle
element instead.
- The
h1
for this challenge is actually visually hidden while the "The Bright Future of Web 3.0?" is anh2
heading.
- For your "Read More" button, you are nesting the
anchor
andbutton
element; This is not allowed. You can only use one or the other. For this challenge, it will be theanchor
element.
- In
<section class="new">
, the articles should be built using anunordered list
while the articles in the<section class="numbered">
will beordered list
.
- The articles headings in the "new" and
numbered
sections should beh3
since it is not allowed to skip heading levels.
- In the
<section class="numbered">
there should be a visually hiddenh2
heading.
- Numbers are never headings.
If you have any questions or need further clarification, feel free to reach out to me.
Happy Coding! πΎ
Marked as helpful
1
Nathan Soussanaβ’ 40
@nathansoussana
Posted
@vcarames thank you very much for your helpful and detailed review π
0