News homepage solution

Community feedback

• 

  Harsh Kumar•3,850

  @thisisharsh7

  Posted 27 days ago

  Fantastic work on completing the challenge! Your modular CSS structure, using custom properties and organized imports, enhances maintainability and readability—great use of --spacing-* and --font-size-* variables!

  • For improvements, consider optimizing image loading with loading="lazy" on non-critical images to boost performance. The .trending__img fixed height (300px) might cause distortion on some devices; using aspect-ratio could maintain proportions dynamically. In the mobile menu, the 60vw width might feel narrow on smaller screens—test a wider range (e.g., 80vw) for usability. For the popular section, adding min-width to .popular__text could prevent text wrapping issues on smaller screens.

  • To level up, explore CSS-in-JS or utility-first frameworks like Tailwind for faster iteration. The JavaScript for menu toggling is clean but could include keyboard event listeners for enhanced accessibility.

  Overall, a polished solution, minor layout tweaks for perfection!

  01

  Marked as helpful