News homepage with CSS Grid and Sass

Solution retrospective
Wondering if anyone knows a technique for getting the mobile nav to animate a 'slide back in' when it is closed? Otherwise, general coding practices and suggestions are welcome! Thank you! :)
Please log in to post a comment
Log in with GitHubCommunity feedback
- @AdrianoEscarabote
Hi misty, how are you? I really liked the result of your project, but I have some tips that I think you will enjoy:
I noticed that you used a
button
in which case the best option would be ana
, because in my head when a person clicks on a button written Read more, he is not confirming a form, or something like, it will be redirected to another page, to read more about!To resolve do this:
<a href="/">Read more</a>
I noticed that in higher resolutions the content is stretching a lot and this is harming the design of the project, to fix this in a simple way we can use a
max-width
.body { max-width: 1440px; }
The rest is great!
I hope it helps... 👍
Marked as helpful
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord